Move logging into worker processing loop: #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #882 +/- ##
==========================================
+ Coverage 51.19% 51.23% +0.03%
==========================================
Files 33 33
Lines 1459 1458 -1
==========================================
Hits 747 747
+ Misses 666 665 -1
Partials 46 46 ☔ View full report in Codecov by Sentry. |
This sets a new logger with values for each loop. Previously the loop was being set outside of the loop and all .With functions were persisted across loops. This made the logs almost unreadable when multiple workflows were run by a single worker. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
fix-tink-worker-logging
branch
from
71ebd15 to
fc5a3c4
Compare
chrisdoherty4
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This sets a new logger with values for each loop. Previously the loop was being set outside of the loop and all
.Withfunctions persisted across loops. This made the logs almost unreadable when multiple workflows were run by a single worker.Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: