-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added terraform into deploy dir #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kdeng3849 Since you are moving setup.sh
to /deploy
you will need to change a few things in the script and update the docs as well.
I think instead of moving |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think instead of moving setup.sh into deploy dir you can directly copy that file to the provisioner machine through terraform script at a certain place and then you can login to provisioner and run that script.
@parauliya I actually think it's better to keep it separate. I remember there were sometimes problems with terraform not being able to ssh into the provisioner and then it just stops the entire operation. |
I agree with you on that but still I do not see a reason for moving the |
The thought was to keep all things setup together and also to have the generated |
@parauliya @gauravgahlot I will first move |
* added terraform and moved everything setup into the deploy dir * moved back setup.sh * changed default worker plan
* added terraform and moved everything setup into the deploy dir * moved back setup.sh * changed default worker plan
demo-v2
branchinput.tf
to use user api keymovedsetup.sh
into deploy directory