Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #41 - Added sample hardware data in setup guide #44

Merged
merged 6 commits into from
May 21, 2020
Merged

Fixed issue #41 - Added sample hardware data in setup guide #44

merged 6 commits into from
May 21, 2020

Conversation

gauravgahlot
Copy link
Contributor

@gauravgahlot gauravgahlot commented May 14, 2020 •
edited
Loading

Changes

  • added minimal hardware data to the setup page
  • added a page to describe hardware data in detail
  • preview here

Signed-off-by: Gaurav Gahlot [email protected]

@gauravgahlot gauravgahlot added the kind/documentation Categorizes issue or PR as related to documentation. label May 14, 2020
@gauravgahlot gauravgahlot self-assigned this May 14, 2020
@gauravgahlot gauravgahlot linked an issue May 14, 2020 that may be closed by this pull request
Update docs to provide more information about what "hardware data" is #41
Closed
@gauravgahlot gauravgahlot requested a review from parauliya May 14, 2020 07:28
iaguis
iaguis suggested changes May 14, 2020
View reviewed changes
Copy link

@iaguis iaguis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit. I tested this and it worked for me 👍

content/setup/packet/hardware-data.md Outdated Show resolved Hide resolved
@gauravgahlot gauravgahlot requested a review from iaguis May 21, 2020 07:33
parauliya
parauliya approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@parauliya parauliya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parauliya parauliya merged commit 7d9244e into tinkerbell:master May 21, 2020
@gauravgahlot gauravgahlot deleted the fix-41-hw-data branch May 21, 2020 13:05
@gauravgahlot gauravgahlot mentioned this pull request May 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parauliya parauliya parauliya approved these changes

@iaguis iaguis Awaiting requested review from iaguis

Assignees

@gauravgahlot gauravgahlot

Labels
kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update docs to provide more information about what "hardware data" is
3 participants
@gauravgahlot @iaguis @parauliya