Skip to content
This repository has been archived by the owner on Dec 16, 2023. It is now read-only.

Update Everforest theme #15

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Update Everforest theme #15

merged 1 commit into from
Aug 26, 2022

Conversation

antoineco
Copy link
Contributor

@antoineco antoineco commented Aug 21, 2022

Fixes #13

  • Update outdated colors based on Everforest's default dark medium variant.
  • Document each color based on its name in the Everforest palette (palette1, palette2)

Result:

b16-everforest


IMPORTANT NOTICE:

The order of the colors doesn't match the typical base16 color order. This is a deliberate decision to remain as close as possible to the semantic meaning of the Everforest colors, where functions are green, keywords red, strings aqua, constants purple, etc.

Base16 doesn't mandate that themes adopt red for keywords, orange for constants, etc. In fact, there are multiple base16 themes which color order doesn't match the default theme. However, I also know that the original base16 spec has a few flaws — such as "variables AND diff deleted MUST always be the same color" — so if you want me to stay more conservative regarding base16 semantics, and swap the colors like one of the two alternatives below, just let me know!

alt1 (strings and functions retain the Everforest semantics)

b16-everforest-alt1

alt2 (nothing retains the Everforest semantics)

b16-everforest-alt1

@antoineco
Copy link
Contributor Author

Sample - Go file with Vim-Go syntax and all possible syntax highlighting groups enabled

image

Sample - Diff

image

image

@belak
Copy link
Member

belak commented Aug 26, 2022

Thanks, this looks good to me! In the future, we're considering adding semantic names, so you'd be able to have your colors in a palette and would be able to specify "variables are red", but that work is a ways off.

@belak belak merged commit 0037780 into tinted-theming:main Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(everforest) Outdated color palette
2 participants