Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyRadio template repository #43

Merged
merged 3 commits into from
Jul 5, 2022

Conversation

edunfelt
Copy link

@edunfelt edunfelt commented Jul 5, 2022

No description provided.

@joshgoebel
Copy link
Contributor

joshgoebel commented Jul 5, 2022

This looks like the main pyradio repo, not a Base16 template repo.

Is the link wrong?

@edunfelt
Copy link
Author

edunfelt commented Jul 5, 2022

@joshgoebel gah, how silly of me! I copied the wrong link it seems, thank you for double checking. I fixed it now.

@joshgoebel
Copy link
Contributor

What does the temp dir during build do for you? It looks like you're just linking to the existing templates directory... so I'm not sure how a symlink helps? Just curious.

@joshgoebel joshgoebel merged commit 9136b83 into tinted-theming:main Jul 5, 2022
@edunfelt
Copy link
Author

edunfelt commented Jul 5, 2022

Hi @joshgoebel,

Good question 😅

It was some way I did this to get around needing to actually put the working files in the base16 directory structure required by the builder, by linking the template to base16/templates/base16-pyradio and then moving out the generated themes. Quite cumbersome.

I also realize there is still some artifacts left in the makefile from previously using base16-builder-python that I got an issue with just today due to #39. :/

Suggestions?

@joshgoebel
Copy link
Contributor

joshgoebel commented Jul 5, 2022

I'm not sure how you're doing things... personally I'd just checkout the template INTO the base16 folder and then manage it from there, as hinted at in the node builder instructions. So them the build assets are exactly where you need them, git add, git commit, done.

@edunfelt
Copy link
Author

edunfelt commented Jul 5, 2022

Right, so the root of the repo would then contain the base16/ directory with its subdirectories containing templates and themes if I understand things correctly? I just wanted to avoid that extra click of going into the base16 directory for downloading/viewing the themes and templates.

Sorry for being so obtuse, but I don't frequently work with these types of files.

@joshgoebel
Copy link
Contributor

joshgoebel commented Jul 5, 2022

  • base16
    • schemes (a checkout of the main schemes repo)
    • templates
      • your_template (a checkout of your template)

And just maintain your template from that folder. (or you could symlink it)

To build (from inside your you_template):

cd ../../..
base16 build
cd base16/templates/your_template

Of course if you wrap this in a tiny script you don't need to cd back as when the script dies you'll be returned automagicaly. The node builder README has an example.

Every once in a while you need to jump into schemes to pull down changes, etc...

@belak
Copy link
Member

belak commented Jul 5, 2022

We've also got the Go builder available as a Github action. I have an example in the base16-emacs repo:

https://github.com/base16-project/base16-emacs/blob/main/.github/workflows/update.yml

@edunfelt
Copy link
Author

edunfelt commented Jul 5, 2022

Ah right I understand now, thank you for taking the time to explain.

I saw the example in the builder README but I was still a bit confused as you understand. I will consider making some changes to simplify things.

Good evening/morning :)

@edunfelt
Copy link
Author

edunfelt commented Jul 5, 2022

We've also got the Go builder available as a Github action. I have an example in the base16-emacs repo:

https://github.com/base16-project/base16-emacs/blob/main/.github/workflows/update.yml

That's cool! Thanks for the example :)
I'm using the node builder in an action currently: https://github.com/edunfelt/base16-pyradio/blob/main/.github/workflows/update.yml

@edunfelt edunfelt deleted the pyradio-template branch July 5, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants