Add httptest package #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
What else do I need to do to get my pull request accepted? |
|
Did you need any adjustments from upstream or was this just imported and it works out of the box? |
|
I made a few changes, for instance drop TLS support. All differences documented with |
|
I just ran into this myself, would love to see this merged if possible 🙂 |
|
I tested this PR against the example/net examples and found no issues. I did notice the PR is against 'dev' branch, not 'main', and 'dev' is a few behind main. Other than that, this PR LGTM for the next tinygo release. |
|
Thanks for adding this @dshemin and for review @scottfeldman now merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will bring httptest package from the original Go. This package will help to test some WASM modules on my current project and will allow to use assertion packages like testify.