Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

machine/itsybitsy-nrf52840: add support for Adafruit Itsybitsy nrf52840 #1243

Merged
merged 3 commits into from
Aug 25, 2020
Merged

machine/itsybitsy-nrf52840: add support for Adafruit Itsybitsy nrf52840 #1243

merged 3 commits into from
Aug 25, 2020

Conversation

deadprogram
Copy link
Member

This PR adds support for Adafruit Itsybitsy nrf52840 Express board.

@sago35
Copy link
Member

sago35 commented Jul 19, 2020

product page: https://www.adafruit.com/product/4481
nRF52840 datasheet: https://infocenter.nordicsemi.com/pdf/nRF52840_PS_v1.0.pdf
PinOut: https://learn.adafruit.com/adafruit-itsybitsy-nrf52840-express/pinouts
Schematics: https://learn.adafruit.com/assets/87158

sago35
sago35 reviewed Jul 19, 2020
View reviewed changes
Copy link
Member

@sago35 sago35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the following.

src/machine/board_itsybitsy-nrf52840.go Outdated Show resolved Hide resolved
src/machine/board_itsybitsy-nrf52840.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@bgould bgould mentioned this pull request Aug 1, 2020
Merged
@deadprogram deadprogram added this to the v0.15 milestone Aug 19, 2020
aykevl
aykevl approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@aykevl aykevl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (but perhaps others want to take a look).

@deadprogram
Copy link
Member Author

OK, now squash/merging. Thank you everyone for the help on this!

@deadprogram deadprogram merged commit 29d65cb into dev Aug 25, 2020
@deadprogram deadprogram deleted the itsybitsy-nrf52840 branch August 25, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sago35 sago35 sago35 left review comments

@bgould bgould bgould left review comments

@aykevl aykevl aykevl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.15
Development

Successfully merging this pull request may close these issues.
4 participants
@deadprogram @sago35 @aykevl @bgould