Initial Go 1.20 support #3391
Merged
Initial Go 1.20 support #3391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for unsafe.SliceData, unsafe.String, and unsafe.SringData that were introduced in Go 1.20.
This is needed for Go 1.20 support.
This function provides a mechanism to watch for changes to the GODEBUG environment variable. For now, we'll not implement it. It might be useful in the future, when it can always be added.
This is expected starting with Go 1.20. I've also applied the same modification to syscall_libc.go so that setenv is only called in a single place.
Not all features work yet, but allow it to compile with this Go version.
deadprogram
approved these changes
Jan 17, 2023
|
Thank you for working on this @aykevl now merging. |
This was referenced Jan 23, 2023
|
If I've applied this correctly this time, I think there's only one failure now, #3408. |
aykevl
added a commit
that referenced
this pull request
Feb 2, 2023
I missed this in #3391 (because I didn't test on Windows, my fault).
aykevl
added a commit
that referenced
this pull request
Feb 2, 2023
I missed this in #3391 (because I didn't test on Windows, my fault).
aykevl
added a commit
that referenced
this pull request
Feb 2, 2023
I missed this in #3391 (because I didn't test on Windows, my fault).
aykevl
added a commit
that referenced
this pull request
Feb 3, 2023
I missed this in #3391 (because I didn't test on Windows, my fault).
deadprogram
pushed a commit
that referenced
this pull request
Feb 14, 2023
I missed this in #3391 (because I didn't test on Windows, my fault).
waj334
pushed a commit
to waj334/tinygo
that referenced
this pull request
Feb 24, 2023
I missed this in tinygo-org#3391 (because I didn't test on Windows, my fault).
LiuJiazheng
pushed a commit
to LiuJiazheng/tinygo
that referenced
this pull request
Aug 20, 2023
I missed this in tinygo-org#3391 (because I didn't test on Windows, my fault).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all features are supported yet and some tests still fail, but most code should compile with these patches.
We can work on full support with this merged, to get it in shape for Go 1.20 when it is released.