compiler: link .syso files found in Go package directories #4593
Conversation
|
While this is one option, I don't think we should be going for this solution. The reason is that Do you have any objections against a special-purpose pragma for this purpose? It would basically just add the file to the linker, nothing else. Also, since this is going to be generated code and the uglyness is hidden, I don't see any fundamental reason why the |
Among other things, this enables WebAssembly programs to link in custom sections, which can be stored in a relocatable wasm module with a .syso suffix in a package directory. This will simplify the build process for WASI 0.2, removing the need to run 'wasm-tools component embed' with the original source WIT files.
Currently stubbed out (if false). Depends on tinygo-org/tinygo#4593
|
The Cgo hack can’t be used because it creates a circular dependency on package What if I limited this PR to just |
Yeah, you're right.
Limiting to wasm would indeed help against my worries. Or even only accepting a single filename (I don't know, something like |
|
One complication: -Target=wasip2 sets GOARCH=arm GOOS=linux. This means that foo_wasm.syso would not be found. Do you have any plans to change the GOARCH/GOOS handling for architectures that TinyGo supports that Go doesn't? |
Currently stubbed out (if false). Depends on tinygo-org/tinygo#4593
This enables WIT tree-shaking by world or interface, as a precursor for Go package-level component metadata. wit/bindgen: oops wit/bindgen: add WIT generation for each WIT interface (Go package) Currently disabled. wit/bindgen: cgo + linker tricks WIP wit: fix typo wit/bindgen: typo wit: type aliases force transitive dependency on the dependencies of their parent interface wit: prepare for filtering interface contents wit: remove ConstrainTo internal/wasm: stub linking section wit/bindgen: generate .wasm.syso files in each Go package Currently stubbed out (if false). Depends on tinygo-org/tinygo#4593 wit: revise package sorting algorithm This enables wasi:http to sort before wasi:cli. wit/bindgen: more cleanup (path -> pkgPath) wit/bindgen: optionally generate WIT files for each Go package cmd/wit-bindgen-go: --generate-wit option to generate WIT files for each Go package wit/bindgen: generate synthetic worlds in the go:bindgen package namespace
This is an experiment, driven by a need to link in custom sections into the resulting .wasm binary. Using a .syso file in a package directory is a well-known way to accomplish this with other architectures in big Go.
We have a POC that proves this works: ydnar/wasi-http-go#13
Another example: https://tip.golang.org/src/crypto/internal/boring/syso/
@dgryski co-authored this live at WasmCon.