Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix int to byte conversion for large values #89

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Fix int to byte conversion for large values #89

merged 2 commits into from
Aug 7, 2024

Conversation

gulcinuras
Copy link
Contributor

No description provided.

@gulcinuras gulcinuras requested review from Anlerkan and tatata96 August 7, 2024 09:17
@gulcinuras gulcinuras self-assigned this Aug 7, 2024
fergalwalsh
fergalwalsh approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@fergalwalsh fergalwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I did some brief tests with this function and it appears to work properly.

@gulcinuras gulcinuras merged commit fcd809f into main Aug 7, 2024
@gulcinuras gulcinuras deleted the fix/bytes-to-int-util-function branch August 7, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fergalwalsh fergalwalsh fergalwalsh approved these changes

@Anlerkan Anlerkan Anlerkan approved these changes

@tatata96 tatata96 tatata96 approved these changes

Assignees

@gulcinuras gulcinuras

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gulcinuras @fergalwalsh @Anlerkan @tatata96