Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jxl-frame: TOC entry count limit #45

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

EugeneVert
Copy link
Contributor

Copy link
Owner

@tirr-c tirr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Level 10 specifies width * height <= (1 << 40), we can have at most 11 passes from 4 + u(3), and minimum group_dim is 128 (1 << 7), so in an extreme case we have:

  • 1 LfGlobal,
  • (1 << 40) / ((1 << 7) * 8 * (1 << 7) * 8) = 1_048_576 LfGroups,
  • 1 HfGlobal,
  • (1 << 40) / (1 << 14) * 11 = 738_197_504 PassGroups

...and this yields 739 246 082 TOC entries. Well, this feels too large. Maybe I'll just go with 65536.

@tirr-c tirr-c merged commit 2141959 into tirr-c:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants