Add spot colour channel rendering #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EugeneVert
force-pushed
the
spot-colour-channels
branch
2 times, most recently
from
e297c30 to
5c22c28
Compare
tirr-c
reviewed
Jun 12, 2023
crates/jxl-oxide/src/lib.rs
Outdated
| @@ -135,6 +135,7 @@ impl<R: Read> JxlImage<R> { | |||
| image_header: &self.image_header, | |||
| embedded_icc: self.embedded_icc.as_deref(), | |||
| ctx, | |||
| render_spot_colour: true, | |||
There was a problem hiding this comment.
We might need to prevent rendering spot color channels if the image is grayscale.
There was a problem hiding this comment.
Сan we use red color from spot channel as luma and just ignore green and blue as it is now with grayscale images?
There was a problem hiding this comment.
I'm not sure about the semantics of spot color channels on grayscale images; bitstream does not forbid this, but tricolor spot color channel doesn't make sense with grayscale ICC profile. Let's go with emitting a warning for this time.
EugeneVert
force-pushed
the
spot-colour-channels
branch
4 times, most recently
from
66cd781 to
1f2c883
Compare
tirr-c
reviewed
Jun 13, 2023
EugeneVert
force-pushed
the
spot-colour-channels
branch
from
1f2c883 to
fe614fa
Compare
EugeneVert
force-pushed
the
spot-colour-channels
branch
from
fe614fa to
1a0e535
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds rendering of spot color channels by default, a
set_render_spot_colourmethod to enable/disable their rendering and arender_spot_colourmethod to get the value of that flag inJxlRendererRendering of spot channels onto color channels is disabled during conformance testing since they are tested as separate channels
fixes #15