Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

Theme broke? #6

Closed
patcon opened this issue Feb 11, 2014 · 5 comments
Closed

Theme broke? #6

patcon opened this issue Feb 11, 2014 · 5 comments

Comments

@patcon
Copy link
Contributor

patcon commented Feb 11, 2014

At Feb 4 commit 56888d0:
https://www.evernote.com/shard/s27/sh/d75e852c-cd59-49fa-ae2f-e18c8e0c6df4/4564614a13301e79b11dbbd7c2d9e588

At recent commit 131e378:
https://www.evernote.com/shard/s27/sh/8205d343-6a58-4d70-a5b0-cf6b50a6589e/c79a6723b307cbba384ac2d434f9a9f3

Thought it was something minor, but seems it broke oauth too -- after selecting an account to log in with, I get "Cannot GET /img/glyphicons-halflings.png" and get sent to https://auth.mydomain.com/img/glyphicons-halflings.png

@patcon
Copy link
Contributor Author

patcon commented Feb 12, 2014

On second thought, maybe it's something funny with the cookbook. Don't sweat this. I'll investigate

@patcon
Copy link
Contributor Author

patcon commented Feb 12, 2014

Yeah, just the theme. The other error (oauth) seems like maybe a caching thing...

tizzo added a commit that referenced this issue Feb 12, 2014
…was moved into lib folder and was using a relative path.
tizzo added a commit that referenced this issue Feb 12, 2014
@tizzo
Copy link
Owner

tizzo commented Feb 12, 2014

Ooops, I was reorganizing things and static file serving was being set to a relative path which I obviously broke. That's now fixed.

The redirect to glyph-halflings I have had before. If you aren't authed the url you requested is stashed in your session so that we can redirect you back to your original location when you're in. This is really nice for things like links to jenkins jobs. I think I just need to add that asset to the url white list, I made that change and also added the glyph halflings so that we have them available for future ui improvements.

When you say the oauth thing was a caching problem, do you have auth proxy sitting behind a reverse proxy cache or something?

@tizzo tizzo closed this as completed Feb 12, 2014
@tizzo
Copy link
Owner

tizzo commented Feb 12, 2014

I did also add tests to verify that hose files would be served to anon users.

@patcon
Copy link
Contributor Author

patcon commented Feb 12, 2014

Ah gotcha. That actually seems to explain everything :)

When I mentioned caching, I assumed it was something related to browser or cookie caching, so nope, no rev proxy cache :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants