Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for unique TextFields #332

Merged
merged 5 commits into from
May 17, 2021

Conversation

diesieben07
Copy link
Contributor

Adds support for unqiue on TextField, similar to CharField.
Fixes #331.

@pep8speaks
Copy link

pep8speaks commented May 17, 2021

Hello @diesieben07! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-05-17 21:27:10 UTC

model_clone/tests/test_clone_mixin.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #332 (79821ff) into main (1b7f02a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files           6        6           
  Lines         272      272           
=======================================
  Hits          262      262           
  Misses         10       10           
Impacted Files Coverage Δ
model_clone/mixins/clone.py 95.62% <100.00%> (ø)
model_clone/utils.py 96.87% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b7f02a...79821ff. Read the comment docs.

@jackton1 jackton1 merged commit 668fbd8 into tj-django:main May 17, 2021
@jackton1
Copy link
Member

@all-contributors please add @diesieben07 for test, bug

@allcontributors
Copy link
Contributor

@jackton1

I've put up a pull request to add @diesieben07! 🎉

@jackton1
Copy link
Member

@all-contributors please add @diesieben07 for code

@allcontributors
Copy link
Contributor

@jackton1

I've updated the pull request to add @diesieben07! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextField is not supported with unique value generation
3 participants