Rename columns to helpWidth #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadowspawn
added
the
pending release
shadowspawn
removed
the
pending release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
I named the Help property which determines help wrapping
columns, since the default value isprocess.stdout.columnsorprocess.stderr.columns. But this does not describe what it is used for in Help or what custom implementations should be supplying. Naming it based on the purpose could make it clearer for supplying custom values.Solution
Rename:
columns->helpWidthgetOutColumns()->getOutHelpWidth()getErrColumns()->getErrHelpWidth()Release Note
This is a breaking change from the first prerelease, but does not need to appear in the final release notes.