Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove API link, which is not being updated #988

Merged
merged 2 commits into from
Jul 3, 2019

Conversation

shadowspawn
Copy link
Collaborator

Resolves #985

We are maintaining the README, and now have TypeScript too. We will keep maintaining the JSDoc but for built-in suggestions for IDEs that support it rather than for generating a stand-alone reference (which was not being updated).

Removing the API link from both READMEs.

@shadowspawn shadowspawn added this to the v3.0.0 milestone Jul 3, 2019
Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Readme.md Outdated
@@ -5,8 +5,7 @@
[![NPM Downloads](https://img.shields.io/npm/dm/commander.svg?style=flat)](https://npmcharts.com/compare/commander?minimal=true)
[![Install Size](https://packagephobia.now.sh/badge?p=commander)](https://packagephobia.now.sh/result?p=commander)

The complete solution for [node.js](http://nodejs.org) command-line interfaces, inspired by Ruby's [commander](https://github.com/commander-rb/commander).
[API documentation](http://tj.github.com/commander.js/)
The complete solution for [node.js](http://nodejs.org) command-line interfaces, inspired by Ruby's [commander](https://github.com/commander-rb/commander).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be better to erase the leading space.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that, thanks. Done.

@shadowspawn shadowspawn merged commit 270cdf3 into tj:release/3.0.0 Jul 3, 2019
@shadowspawn shadowspawn deleted the feature/985-drop-api branch July 3, 2019 09:29
@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Jul 27, 2019
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Aug 12, 2019
@shadowspawn shadowspawn mentioned this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants