Add option to specify executable file name #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because there was a major upgrade.
Node.js 6 is EOL.
I get the following error in a library that does not support Node.js 6.
```
node_modules/eslint/lib/cli-engine/cli-engine.js:257
...calculateStatsPerFile(messages)
^^^
```
Upgrade packages
…mo/commander.js into abetomo-feature_specify_subcommand
- add to README - rename option - include support for executableFile for alias and default command - consistent use of node to launch javascript files
|
Example call for interested readers: |
This was referenced Jul 21, 2019
shadowspawn
added
the
pending release
|
Available now as a prerelease. See #1001 |
|
Shipped in v3: https://github.com/tj/commander.js/releases/tag/v3.0.0 |
shadowspawn
removed
the
pending release
|
Hi there ! Could it be that you forgot to update the typescript definition for the option object passed to the command function ? from interface CommandOptions {
noHelp?: boolean;
isDefault?: boolean;
} |
|
Drat! Thanks @CaptainQuirk, I'll fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #854 to add command option for specifying executable file name, and overriding default name construction.
executableFileexecutableFilefor alias and default executable tooexecutableFileand keep behaviour consistent(Includes latest commits in master, pulled in when merging #854.)