Check exit code directly, not indirectly with $?

tj · Mar 23, 2019 · fb47010 · fb47010
1 parent 1866217
commit fb47010
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/bin/n b/bin/n
@@ -549,8 +549,7 @@ install() {
   is_ok "$url" || is_oss_ok "$url" || abort "invalid version $version"
 
   log mkdir "$dir"
-  mkdir -p "$dir"
-  if [ $? -ne 0 ] ; then
+  if ! mkdir -p "$dir"; then
     abort "sudo required"
   else
     touch "$dir/n.lock"