Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cslapps): update App.image_url #1626

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fix(cslapps): update App.image_url #1626

merged 1 commit into from
Mar 19, 2024

Conversation

krishnans2006
Copy link
Member

Proposed changes

  • Use CharField instead of URLField
  • Lower max_length

Brief description of rationale

  • The validators used by URLField don't allow for updating the field in Django Admin, when in the form /static/img/cslapps/app.ico.
  • The current max_length is unnecessarily large (and could cause errors with some database backends).

- use CharField instead of URLField to enable Django Admin
- make max_length more reasonable
@coveralls
Copy link

Coverage Status

coverage: 80.142%. remained the same
when pulling 9e373ef on krishnans2006:dev
into 21911f1 on tjcsl:dev.

@krishnans2006 krishnans2006 requested a review from alanzhu0 March 19, 2024 00:47
Copy link
Member

@NotFish232 NotFish232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NotFish232 NotFish232 merged commit f90c060 into tjcsl:dev Mar 19, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants