Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): fix CODEOWNERS file syntax #1634

Closed
wants to merge 1 commit into from
Closed

chore(docs): fix CODEOWNERS file syntax #1634

wants to merge 1 commit into from

Conversation

krishnans2006
Copy link
Member

Proposed changes

  • Move code owners to the same line

Brief description of rationale

According to the GitHub docs,

If you want to match two or more code owners with the same pattern, all the code owners must be on the same line. If the code owners are not on the same line, the pattern matches only the last mentioned code owner.

@krishnans2006 krishnans2006 self-assigned this Mar 25, 2024
alanzhu0
alanzhu0 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@alanzhu0 alanzhu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Krishnan!

@coveralls
Copy link

coveralls commented Mar 25, 2024 •
edited
Loading

Coverage Status

coverage: 80.218% (+0.07%) from 80.147%
when pulling e3d6a66 on krishnans2006:dev
into 41a3e09 on tjcsl:dev.

@krishnans2006 krishnans2006 force-pushed the dev branch 2 times, most recently from 50f75d9 to e3d6a66 Compare March 25, 2024 04:30
@krishnans2006 krishnans2006 mentioned this pull request Mar 25, 2024
Merged
@krishnans2006
Copy link
Member Author

Replaced by #1635.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanzhu0 alanzhu0 alanzhu0 approved these changes

@NotFish232 NotFish232 Awaiting requested review from NotFish232

Assignees

@krishnans2006 krishnans2006

Labels
type/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krishnans2006 @coveralls @alanzhu0