feat: update favicons and meta tags #1654
Conversation
krishnans2006
force-pushed
the
favicon-update
branch
from
6837df4 to
ffc5190
Compare
krishnans2006
force-pushed
the
favicon-update
branch
from
ffc5190 to
89589cc
Compare
|
Can you list the visual changes this produces, just for reference and since this is fairly significant? |
There was a problem hiding this comment.
This one looks all black - not the grey the other icons use. Is that intended?
There was a problem hiding this comment.
Yep, it's intended. The Safari pinned tab icon is supposed to be a silhouette and gets colored by the color field in meta.html line 30.
There was a problem hiding this comment.
Also, this one is off center, is that intended?
There was a problem hiding this comment.
It's intended - it leaves space for text under the icon.
Sure. As summarized above, besides speed/quality improvements and re-organization, this PR affects the following visuals: New: Windows 8/10 (Metro Icon)
New: Safari (Pinned Tab Icon)
|
Proposed changes
static/img/faviconmeta.htmlmask-icon)browserconfig.xml)Brief description of rationale
Ion does not follow some best practices for favicons. These changes were inspired by RealFaviconGenerator and commits like tjcsl/tin@92c3258.