ref(webhook): return error if unable to parse group key

Addresses feedback from another PR prometheus#4089 (comment) Signed-off-by: TJ Hoplock <[email protected]>
tjhop · Nov 6, 2024 · 38ee8ad · 38ee8ad
1 parent f6b942c
commit 38ee8ad
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/notify/webhook/webhook.go b/notify/webhook/webhook.go
@@ -82,12 +82,10 @@ func (n *Notifier) Notify(ctx context.Context, alerts ...*types.Alert) (bool, er
 
 	groupKey, err := notify.ExtractGroupKey(ctx)
 	if err != nil {
-		// @tjhop: should we `return false, err` here as we do in most
-		// other Notify() implementations?
-		n.logger.Error("error extracting group key", "err", err)
+		return false, err
 	}
 
-	// @tjhop: should we debug log the key here like most other Notify() implementations?
+	n.logger.Debug("extracted group key", "incident", groupKey)
 
 	msg := &Message{
 		Version:         "4",