Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build #9

Open
tjvr opened this issue May 13, 2017 · 1 comment
Open

Fix the build #9

tjvr opened this issue May 13, 2017 · 1 comment

Comments

@tjvr
Copy link
Owner

tjvr commented May 13, 2017

  • Is Webpack really that great anyway?

  • I had to do this locally, to get Phosphorus to play nicely with the tests:

    var P = window.P = (function() {

    We should probably send this patch upstream, or find a workaround that doesn't require doing this (global maybe?)

  • We should generally make sure the built output is ready for consumption. Are we building the CSS properly yet, for instance?

@CosmicWebServices
Copy link

I am confused why is it not building - IcyCoder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants