-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #170 compile fail on aarch64 #171
fix: #170 compile fail on aarch64 #171
Conversation
Co-authored-by: Joshua Liebow-Feeser <[email protected]>
If you're feeling really ambitious, maybe you could add CI jobs for arm and aarch64? @tkaitchuck would have to say whether they're interested in taking such a change, but I assume they'd be interested. |
@joshlf Hi, I'd love to, but I'm not quite sure if github action provides aarch64 machines? |
Yeah you'd probably want to cross-compile using If you want to do a fuller overhaul (I'd run it by @tkaitchuck and probably do it in a different PR), you could use a job matrix like we do in zerocopy: https://github.com/google/zerocopy/blob/e2ae4f821fea88ad2a4c4ca3478cf595bef4b5f6/.github/workflows/ci.yml#L23 |
Thanks for your suggestion! |
Co-authored-by: Joshua Liebow-Feeser <[email protected]>
Co-authored-by: Joshua Liebow-Feeser <[email protected]>
Closes #1707 Ref tkaitchuck/aHash#171
Closes #1707 Ref tkaitchuck/aHash#171
Closes #1707 Ref tkaitchuck/aHash#171
Closes #1707 Ref tkaitchuck/aHash#171
fixes #170