-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOC2: Updates nitro-cli to v1.3.1 #472
Conversation
Is there a way we can split up these cargo.lock updates? |
@james-callahan unfortunately I don't think that's an option. There's a lot of updates in cargo.lock because nitro-cli is a crate with a lot of dependencies itself: https://github.com/aws/aws-nitro-enclaves-cli/blob/837e1146ea76e1e9e4f2d1ad3e35a60811152473/Cargo.toml#L9-L30 If we want to update this crate we have to update the transitive dependencies in our cargo.lock, no way around it I'm afraid. And I bet some of nitro-cli's dependencies themselves have many dependencies and so on and so forth. How deep down the rabbit hole should we go here? My proposal is to review https://github.com/aws/aws-nitro-enclaves-cli/compare/v1.2.2..v1.3.1 (just did it, looks reasonable to me, nothing malicious), and we can wait until we have better tooling to review all of the transitive dependency updates. It's impractical to do it manually right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using experimental review diff analysis tooling, already-trusted-in-rust-core-projects comparisons for versions, diff review and other steps, @lrvick and I were able to substantially reduce the amount of necessary review and manually go through all remaining dependency code changes.
I can therefore approve this PR and propose someone from @tkhq/qos-operators approves it to unblock the merge 👍
CC @r-n-o @jack-kearney as status update. |
@jack-kearney @lrvick can one of you formally approve this? Thanks! |
Summary & Motivation (Problem vs. Solution)
This PR addresses security vulnerabilities by updating key dependencies to their latest, patched versions, ensuring SOC2 compliance. Specifically this PR updates
nitro-cli
tov1.3.1
.Vulnerable Package Updates
1.1.0
1.3.0
0.11.1
0.12.1
0.37.15
0.38.34
Required Package Updates
1.2.2
1.3.1
shlex
,vmm-sys-util
,rustix
How I Tested These Changes
make
in rootPre merge check list