Fix customizable select multiple on android

This patch prevents appearance:base-select from getting applied to selects with the multiple attribute in order to prevent the new mode from applying to <select multiple> on android which uses a picker popup. Bug: 386249939 Change-Id: I6d986d0814b376085a026c9b6c6ca9c42abbad71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6128036 Commit-Queue: Joey Arhar <[email protected]> Reviewed-by: Traian Captan <[email protected]> Cr-Commit-Position: refs/heads/main@{#1402744}
tkntjsdw · Jan 7, 2025 · 54f2c8f · 54f2c8f
1 parent f10fb64
commit 54f2c8f
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/...ics/forms/the-select-element/customizable-select/select-multiple-base-appearance-ref.html b/...ics/forms/the-select-element/customizable-select/select-multiple-base-appearance-ref.html
@@ -9,3 +9,7 @@
   <option>three</option>
   <option>four</option>
 </select>
+
+<select multiple>
+  <option selected>option</option>
+</select>
diff --git a/...mantics/forms/the-select-element/customizable-select/select-multiple-base-appearance.html b/...mantics/forms/the-select-element/customizable-select/select-multiple-base-appearance.html
@@ -1,4 +1,5 @@
 <!DOCTYPE html>
+<html class=reftest-wait>
 <link rel=author href="mailto:[email protected]">
 <link rel=match href="select-multiple-base-appearance-ref.html">
 
@@ -18,3 +19,16 @@
   <option>three</option>
   <option>four</option>
 </select>
+
+<select id=needsmultiple>
+  <option selected>option</option>
+</select>
+
+<script>
+requestAnimationFrame(() => {
+  document.getElementById('needsmultiple').setAttribute('multiple', '');
+  requestAnimationFrame(() => {
+    document.documentElement.classList.remove('reftest-wait');
+  });
+});
+</script>