Skip to content

Commit

Permalink
Only generate ::column::scroll-marker elements that generate boxes
Browse files Browse the repository at this point in the history
The code asserts that a ::scroll-marker always have a LayoutObject. This
is ensured in Element::CreatePseudoElementIfNeeded() for other pseudo
elements.

Bug: 386415620
Change-Id: Id2ba77b654e3af46fa29da886f856799ae6560c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6113610
Reviewed-by: Morten Stenshorne <[email protected]>
Commit-Queue: Rune Lillesveen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1401734}
  • Loading branch information
lilles authored and chromium-wpt-export-bot committed Jan 3, 2025
1 parent e27025b commit 7e05dc9
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions css/css-overflow/column-scroll-marker-no-content-crash.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<!DOCTYPE html>
<title>::column::scroll-marker without content should not crash</title>
<link rel="help" href="https://crbug.com/386415620">
<style>
#container {
overflow: hidden;
width: 10px;
column-count: 1;
scroll-marker-group: before;
}
#container::column::scroll-marker {
display: inline;
}
</style>
<p>PASS if no crash.</p>
<div id="container">Two columns</div>

0 comments on commit 7e05dc9

Please sign in to comment.