Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Conflict fixes and regenerated cython #1

Merged
merged 9 commits into from
Jun 30, 2019
Merged

Conversation

zssherman
Copy link

Hi @tkralphs , I noticed you had the pull request for python 3 and your trying to get the code into the master of CyLP. Fixed the conflict involving the GomoryCutGenerator.py file which was a print statement mismatch. With the two cython file conflicts, cylp/cy/CyCoinModel.cpp and cylp/cy/CyOsiCuts.cpp, i reset them, and regenerated with cython, since the conflict for those seem to be a mismatch is two different cython compiled versions between different cython releases. Some commits behind in the master were also added, unless those were missing from this py3 branch for a reason? The code did work for python 3.7 and 3.6 for me, but figured I do a pull request to yours and it should fix the conflict in the pull request python3support, let me know if this version works for you.

@tkralphs
Copy link
Owner

Hi @zssherman, thanks, this is helpful and also good timing for a ping to get back to this. I wanted to let the pull request sit for a while before merging it to see if any problems arose with the pre-release version I put up, but I've gotten no complaints so far. I hope this means all is well and not that no one is using it! From what I've seen, at least some people are using it. I don't know if I realized there were merge conflicts that had to be resolved, thanks for doing that. I'll take a look at this and probably merge everything into master in the next few days.

@tkralphs tkralphs merged commit fa2f5f1 into tkralphs:py3 Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants