MNT: Conflict fixes and regenerated cython #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @tkralphs , I noticed you had the pull request for python 3 and your trying to get the code into the master of CyLP. Fixed the conflict involving the GomoryCutGenerator.py file which was a print statement mismatch. With the two cython file conflicts, cylp/cy/CyCoinModel.cpp and cylp/cy/CyOsiCuts.cpp, i reset them, and regenerated with cython, since the conflict for those seem to be a mismatch is two different cython compiled versions between different cython releases. Some commits behind in the master were also added, unless those were missing from this py3 branch for a reason? The code did work for python 3.7 and 3.6 for me, but figured I do a pull request to yours and it should fix the conflict in the pull request python3support, let me know if this version works for you.