Skip to content

Commit

Permalink
Automatically merged updates to draft EIP(s) 2535 (ethereum#2979)
Browse files Browse the repository at this point in the history
Hi, I'm a bot! This change was automatically merged because:

 - It only modifies existing Draft or Last Call EIP(s)
 - The PR was approved or written by at least one author of each modified EIP
 - The build is passing
  • Loading branch information
mudgen authored and tkstanczak committed Nov 7, 2020
1 parent c11cddf commit 03735bf
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions EIPS/eip-2535.md
Original file line number Diff line number Diff line change
Expand Up @@ -313,11 +313,11 @@ The `diamondCut` function does nothing if a supplied function selector is alread

After adding/replacing/removing functions the `_calldata` argument is executed with `delegatecall` on `_init`. This execution is done to initialize data or setup or remove anything needed or no longer needed after adding, replacing and/or removing functions.

If the `_init` value is `address(0)` then `_calldata` is executed with `delegatecall` on the diamond itself.
If the `_init` value is `address(0)` then `_calldata` must contain 0 bytes or the transaction reverts.

If `_init` is `address(0)` and `_calldata` contains 0 bytes then `_calldata` execution is skipped. `_calldata` is not executed and the `diamondCut` call can complete successfully.
If the `_init` value is not `address(0)` then `_calldata` must contain more than 0 bytes or the transaction reverts.

If `_init` is not `address(0)` and `_calldata` contains 0 bytes then it is an error and `diamondCut` reverts.
If `_init` is `address(0)` and `_calldata` contains 0 bytes then `_calldata` execution is skipped. `_calldata` is not executed and the `diamondCut` call can complete successfully.

#### DiamondCut Event

Expand Down

0 comments on commit 03735bf

Please sign in to comment.