Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl wait: add page #15441

Merged
merged 3 commits into from
Jan 4, 2025
Merged

Conversation

maze88
Copy link
Contributor

@maze88 maze88 commented Jan 4, 2025

First time contributing here, but I believe I ticked all the boxes properly...!

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.

This PR should close issue #14860.

The example commands I provide here reflect my personal cheatsheet, which is based my daily experience as DevOps engineer working with Kubernetes.
I believe it is practical and brief, instead of confusing and exhaustive (less is more!).

@CLAassistant
Copy link

CLAassistant commented Jan 4, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added new command Issues requesting creation of a new page or PRs adding a new page for a command. review needed Prioritized PRs marked for reviews from maintainers. labels Jan 4, 2025
@maze88 maze88 force-pushed the feature/kubectl-wait branch from 665407a to fc3f1b8 Compare January 4, 2025 12:04
@spageektti spageektti changed the title kubectl: add page for wait kubectl wait: add page Jan 4, 2025
pages/common/kubectl-wait.md Outdated Show resolved Hide resolved
pages/common/kubectl-wait.md Outdated Show resolved Hide resolved
pages/common/kubectl-wait.md Outdated Show resolved Hide resolved
@spageektti
Copy link
Member

Hi. Thank you so much for your contribution! Welcome to tldr! I have a few suggestions for you.

@maze88 maze88 force-pushed the feature/kubectl-wait branch from fc3f1b8 to 8dc1b6f Compare January 4, 2025 12:21
@maze88
Copy link
Contributor Author

maze88 commented Jan 4, 2025

Hi. Thank you so much for your contribution! Welcome to tldr! I have a few suggestions for you.

I used quotes just because the term specifically appeared also within the example commands.
But I've removed them (they're not critical), since I trust your experience maintaining the project, especially regarding styling.

@spageektti spageektti linked an issue Jan 4, 2025 that may be closed by this pull request
@sebastiaanspeck
Copy link
Member

Thank you for your work. To make it easier for us as reviewers, please do not force-push. This makes reviewing harder and in the end all commits will be squashed.

pages/common/kubectl-wait.md Outdated Show resolved Hide resolved
…command can wait for multiple resources

see example with  for multiple resources.
Copy link
Member

@spageektti spageektti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@spageektti spageektti merged commit ebbb779 into tldr-pages:main Jan 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command. review needed Prioritized PRs marked for reviews from maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page request: kubectl wait
4 participants