Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add organization member: @zdroid #3664

Merged
merged 4 commits into from
Dec 20, 2019
Merged

Add organization member: @zdroid #3664

merged 4 commits into from
Dec 20, 2019

Conversation

zlatanvasovic
Copy link
Contributor

Closes #3663.

mebeim
mebeim requested changes Dec 19, 2019
View reviewed changes
MAINTAINERS.md Show resolved Hide resolved
Aracki
Aracki approved these changes Dec 19, 2019
View reviewed changes
Copy link
Collaborator

@Aracki Aracki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After @mebeim suggestion applied, can be merged!

Welcome @zdroid 🚀

zlatanvasovic and others added 2 commits December 19, 2019 11:13
@zlatanvasovic zlatanvasovic requested a review from mebeim December 19, 2019 10:14
waldyrious
waldyrious requested changes Dec 19, 2019
View reviewed changes
Copy link
Member

@waldyrious waldyrious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the historical record, as discussed previously in #3006.

@zlatanvasovic
Copy link
Contributor Author

@waldyrious Okay, I reverted it. Who is supposed to give the final say, @sbrl maybe?

waldyrious
waldyrious approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@waldyrious waldyrious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Welcome at last, @zdroid!

@waldyrious
Copy link
Member

I'd say this should only be closed once the invite is sent out and accepted. Any of us with merge permissions can merge once we can verify that you're part of the org (remember that your membership should be public).

@sbrl
Copy link
Member

sbrl commented Dec 20, 2019

Hey! Sorry, I've been busy with wrapping up the end of my first PhD semester. Sending invite now :-)

@zlatanvasovic zlatanvasovic merged commit 3037734 into master Dec 20, 2019
@zlatanvasovic zlatanvasovic deleted the zdroid-org-member branch December 20, 2019 22:55
@zlatanvasovic
Copy link
Contributor Author

All set, thanks to everyone!

@tansiret tansiret added the community Issues/PRs dealing with role changes and community organization. label Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnivade agnivade agnivade approved these changes

@mebeim mebeim mebeim approved these changes

@Aracki Aracki Aracki approved these changes

@owenvoke owenvoke owenvoke approved these changes

@waldyrious waldyrious waldyrious approved these changes

Assignees
No one assigned
Labels
community Issues/PRs dealing with role changes and community organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add organization member: @zdroid (more shameless self-promotion)
8 participants
@zlatanvasovic @waldyrious @sbrl @agnivade @owenvoke @Aracki @mebeim @tansiret