Send handshake messages in as few records as possible, send multiple new session tickets #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomato42
changed the title
nmav
reviewed
Jul 4, 2018
|
Thank you, I can verify that I can test https://gitlab.com/gnutls/gnutls/issues/511 using this PR. |
nmav
reviewed
Jul 4, 2018
|
@nmav the amount of tickets sent is now configurable using a command line argument, the default is still two a single NewSessionTicket message from tlslite-ng is 174B long, so the configuration needs to request at least 95 tickets to fill a full record, the upside is that 2^14 % 174 is 28, so the NST will be fragmented if so many get requested |
nmav
previously approved these changes
Jul 26, 2018
tomato42
force-pushed
the
multiple-tickets
branch
from
ca82e09 to
062438c
Compare
|
@nmav finally found some time to update it, could you take a second look? |
tomato42
changed the title
tomato42
changed the title
tomato42
force-pushed
the
multiple-tickets
branch
from
062438c to
e9ce626
Compare
support for sending multiple messages of the same time in single record, coalesce the server encrypted flight and session ticket
to reduce probability of key and IV collision, they need to be derived from a common secret; use TLS 1.3-like derivation mechanism to do that
tomato42
force-pushed
the
multiple-tickets
branch
from
e9ce626 to
ff1178f
Compare
simo5
previously approved these changes
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support for sending multiple messages of the same type in single record,
coalesce the server encrypted flight and session tickets, when
there are multiple to be sent
add support for sending multiple session tickets
rework key derivation for session tickets to prevent IV collisions
fixes #286
This change is