feat: eslint 9 support

Eslint 9 has removed a couple of methods from the `context` object. Adapt the code to work with both the new and old eslint runtime. More info: https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/
tlvince · Jun 13, 2024 · f9e0798 · f9e0798
1 parent 3ce1766
commit f9e0798
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 6 deletions.
diff --git a/lib/rules/missing-expect.js b/lib/rules/missing-expect.js
@@ -23,7 +23,11 @@ function create (context) {
       if (allowed.indexOf(buildName(node)) === -1) {
         return
       }
-      context.getAncestors().some(function (ancestor) {
+      const ancestors = context.sourceCode
+        ? context.sourceCode.getAncestors(node)
+        : context.getAncestors()
+
+      ancestors.some(function (ancestor) {
         var index = unchecked.indexOf(ancestor)
 
         if (index !== -1) {

diff --git a/lib/rules/new-line-before-expect.js b/lib/rules/new-line-before-expect.js
@@ -29,7 +29,7 @@ module.exports = {
             return
           }
           lastExpectNode = node
-          var sourceCode = context.getSourceCode()
+          var sourceCode = context.sourceCode || context.getSourceCode()
           let prevToken = sourceCode.getTokenBefore(node)
           if (prevToken.value === 'await' || prevToken.value === 'return') {
             node = prevToken

diff --git a/lib/rules/no-promise-without-done-fail.js b/lib/rules/no-promise-without-done-fail.js
@@ -41,7 +41,10 @@ function genReport (node, context) {
     node: node,
     message: 'An "it" that uses an async method should handle failure (use "done.fail")',
     fix: function (fixer) {
-      const lastToken = context.getLastToken(node.parent)
+      const lastToken = context.sourceCode
+        ? context.sourceCode.getLastToken(node.parent)
+        : context.getLastToken(node.parent)
+
       if (!isSemicolon(lastToken)) {
         return fixer.insertTextAfter(node.parent, '.catch(done.fail)')
       } else {

diff --git a/lib/rules/no-unsafe-spy.js b/lib/rules/no-unsafe-spy.js
@@ -31,7 +31,11 @@ function create (context) {
         )
       ) { return }
 
-      if (blocksWhitelistRegexp.test(getParentJasmineBlock(context.getAncestors()))) { return }
+      const ancestors = context.sourceCode
+        ? context.sourceCode.getAncestors(node)
+        : context.getAncestors()
+
+      if (blocksWhitelistRegexp.test(getParentJasmineBlock(ancestors))) { return }
 
       context.report({
         message: 'Spy declared outside of before/after/it block',

diff --git a/lib/rules/prefer-promise-strategies.js b/lib/rules/prefer-promise-strategies.js
@@ -46,7 +46,7 @@ module.exports = {
         },
 
         fix (fixer) {
-          const code = context.getSourceCode()
+          const code = context.sourceCode || context.getSourceCode()
           return [
             // Replace Promise constructor call with its arguments
             fixer.remove(promiseCall.callee),

diff --git a/lib/rules/prefer-toHaveBeenCalledWith.js b/lib/rules/prefer-toHaveBeenCalledWith.js
@@ -9,7 +9,10 @@ function create (context) {
   return {
     Identifier: function (node) {
       if (node.name === 'toHaveBeenCalled') {
-        const tokensBefore = context.getTokensBefore(node, 2)
+        const tokensBefore = context.sourceCode
+          ? context.sourceCode.getTokensBefore(node, 2)
+          : context.getTokensBefore(node, 2)
+
         if (tokensBefore[1] && tokensBefore[1].type === 'Punctuator' && tokensBefore[1].value === '.' &&
             tokensBefore[0] && tokensBefore[0].type === 'Identifier' && tokensBefore[0].value === 'not') {
           return