Give ability to execute scripts #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
maiste
force-pushed
the
fix/issue-13
branch
2 times, most recently
from
97d0755 to
5a1908d
Compare
tmattio
reviewed
Nov 15, 2022
| (cram | ||
| (applies_to example) | ||
| (enabled_if | ||
| (= true %{env:GITHUB_TESTS=false})) |
There was a problem hiding this comment.
I don't understand this: why enable the tests only on the CI?
There was a problem hiding this comment.
We need a container running with Postgres to execute the PostgreSQL test and an SQLite executable available to run the SQLite test. However, opam-repo-ci doesn't support these kinds of tests... This is the only option I've found to ensure we don't break opam-repo-ci when releasing new versions.
There was a problem hiding this comment.
Thanks! I can't come up with a better alternative either, so let's go with this
There was a problem hiding this comment.
We can correct it later if we find something better 👍
tmattio
approved these changes
Nov 15, 2022
|
Thanks for the review and the suggestions! |
kit-ty-kate
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Nov 15, 2022
CHANGES: - Various bug fixes (tmattio/omigrate#12, tmattio/omigrate#14, @maiste)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #13 by importing the possibility to execute
SQL scriptinto theomigrate-sqlite3driver.This is achieved by directly executing the request instead of trying to prepare it.
It requires #12 to be merged first.