Adding Wasm sources and sinks #4
Open
+1,650
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6a8ca4c.
… to make Math library taint aware
Before Array.indexOf and Array.includes had subtle differences in behavior when it came to tainted values or keys when using said functions. This adds some special case for tainted numbers and unboxes them, so that they behave the same. This requires to flag tainted numbers as not bitwise comparable, which might have downstream effects (?)
Before the following code did not work correctly: ```javascript let curr = Number.tainted(10); curr === Number.tainted(10) ``` This fixed this case.
Fixed equality of tainted numbers
This reverts commit a22ae64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces Wasm sinks and sources to Foxhound. We're doing this by storing taint data in ArrayBufferViewObjects, which takes care of TypedArrays and DataViews - the usual suspects for handling Wasm memory.
It's working as intended across most websites, but there are a few things we still need to sort out:
Videos cannot be played on websites that use the Amazon IVS module (e.g., https://ugc.ivsdemos.com/demo1 or https://twitch.tv)
Issues with the GC on tainted arrays
Investigate if the tainting of Wasm export results and JS import arguments are necessary
Propagate and report DataView taints
Testcases for TypedArray and DataViews