Support filtering by both name and category #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woohoo one of the final bits of functionality! - after selecting a pokemon by name, optionally filter entries by desired category - then, randomly select from all matching entries - if no category match is found, fall back to a random selection - if no category is specified, select a random entry like normal
and add a basic unit test
might as well lol
tmck-code
changed the title
tmck-code
changed the title
tmck-code
added a commit
that referenced
this pull request
Mar 27, 2024
Support filtering by both name and category
tmck-code
added a commit
that referenced
this pull request
Mar 27, 2024
Support filtering by both name and category
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Woohoo finally! 🎉
This adds the ability to select a Pokémon using a name and a category (previously it chose by only name, or only category)
Demo
Behold the glory:
