Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitLab formatter #77

Closed
wants to merge 1 commit into from
Closed

Conversation

riyad
Copy link

@riyad riyad commented Jun 11, 2013

Adds the HTML formatter used by GitLab. (also see gitlabhq#1)

@Razer6
Copy link

Razer6 commented Jun 11, 2013

👍

riyad referenced this pull request in gitlabhq/pygments.rb Jun 11, 2013
@dzaporozhets
Copy link

👍

@avtobiff
Copy link

I suppose this should actually go to pygments bitbucket?

https://bitbucket.org/birkenfeld/pygments-main

@dosire
Copy link

dosire commented Oct 5, 2013

@avtobiff If it is needed to submit this on bitbucket I'm willing to do so but pull requests here seem to be merged too: #92

Merging this pull request would allow GitLab to use the original and get rid of our fork. I think this would help pygments and people packaging GitLab for Fedora and Debian, see https://github.com/axilleas/gsoc/blob/master/packaging.md#gitlab-pygmentsrb

Let us know if there is anything we can do to get this resolved.

@tmm1
Copy link
Contributor

tmm1 commented Oct 5, 2013

Please submit this upstream.

@dosire
Copy link

dosire commented Oct 6, 2013

@tmm1 Thanks for commenting. I've had a look at https://bitbucket.org/birkenfeld/pygments-main but they do not seems to be accepting any customer lexers or formatters, so this does not look like a feasible option. If there is anything we can do to make this PR acceptable to you please let us know. If there is nothing we can do we respect that too.

@avtobiff
Copy link

avtobiff commented Apr 3, 2014

@dosire Quoting http://pygments.org/docs/plugins/

Extending The Core

If you have written a Pygments plugin that is open source, please inform us about that. There is a high chance that we’ll add it to the Pygments distribution.

@dosire
Copy link

dosire commented Apr 3, 2014

@riyad I think you can close this since GitLab switched to highlight.js

@riyad
Copy link
Author

riyad commented Apr 3, 2014

done :)

@riyad riyad closed this Apr 3, 2014
@dosire
Copy link

dosire commented Apr 3, 2014

@riyad Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants