Convert StackProf.run / StackProf.result to Ruby #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
approved these changes
May 4, 2021
|
Since this is technically a breaking change, I'm going to bump the major version on master and remove some of the supported Ruby versions. |
This commit is kind of a yak shave. I would like to add thread tracking to stackprof. I want to allow people to optionally dump the thread for which the stack was collected on by doing `StackProf.result(threads: true)` Updating the signature for `result` was kind of hard, so I am refactoring it to be in Ruby. This commit technically breaks the case of someone doing: ```ruby StackProf.start(out: "some_file.data") ... StackProf.result ``` But I think it's strange to ask the start function to dump the file rather than asking the result function. The result function actually writes to the file, so I think it makes more sense to pass the file (or file name) to the result function.
tenderlove
force-pushed
the
more-ruby
branch
from
40481fb to
70f3910
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is kind of a yak shave. I would like to add thread tracking
to stackprof. I want to allow people to optionally dump the thread for
which the stack was collected on by doing
StackProf.result(threads: true)Updating the signature for
resultwas kind of hard, so I amrefactoring it to be in Ruby.
This commit technically breaks the case of someone doing:
But I think it's strange to ask the start function to dump the file
rather than asking the result function. The result function actually
writes to the file, so I think it makes more sense to pass the file (or
file name) to the result function.