Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements conversions of Date, Time and DateTime structs from and into chrono NaiveDate, NaiveTime and NaiveDateTime structs. #89

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Implements conversions of Date, Time and DateTime structs from and into chrono NaiveDate, NaiveTime and NaiveDateTime structs. #89

merged 1 commit into from
Feb 4, 2025

Conversation

AlvaroSierra
Copy link
Contributor

This was described as an option in to add back behind a feature in #35, which this PR does.

tmontaigu
tmontaigu reviewed Jan 30, 2025
View reviewed changes
Copy link
Owner

@tmontaigu tmontaigu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments, otherwise looks good

src/field/types.rs Outdated Show resolved Hide resolved
@AlvaroSierra @tmontaigu
feat: Implements conversions of Date, Time and DateTime structs into …
caf4e34 
…chrono NaiveDate, NaiveTime and NaiveDateTime structs.
@tmontaigu tmontaigu merged commit caf4e34 into tmontaigu:master Feb 4, 2025
2 checks passed
@tmontaigu
Copy link
Owner

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmontaigu tmontaigu tmontaigu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlvaroSierra @tmontaigu