Issues running Rome with --no-skip-current

[mpdifran]

Bug Report

I'm not sure if my project is set up correctly or not, but I can't seem to get Rome to work with the --no-skip-current option.

Steps which explain the enhancement or reproduce the bug

Here's my setup:

GitHub repo:

Faire/ios-protobuf
// Produces FaireProtobuf.framework

Romefile:

cache:
  local: ~/Library/Caches/Rome

repositoryMap:
- swift-protobuf:
  - name: SwiftProtobuf

# Not sure if this is set up properly
currentMap:
- ios-protobuf:
  - name: FaireProtobuf

Rome command:

rome upload --no-skip-current

Current behavior

Rome does not upload for the FaireProtobuf framework.

Suggested behavior

I'd like Rome to cache all Carthage dependencies, including the FaireProtobuf framework when the --no-skip-current is specified.

Why would the enhancement be useful to most users

This is useful for framework projects that need to be pre-cached.

Rome version:

0.23.3.64 - Romam uno die non fuisse conditam.

OS and version:

macOS Big Sur 11.1 (20C69)

[tmspzz]

This is equivalent to Carthage's --no-skip-current. Try removing the repositoryMap.

You can check in the integration tests of the project how this is set up for Alamofire I think

[mpdifran]

Ah thanks for the tip. Looks like the integration tests are using this Romefile:

cache:
  local: rome-local-cache
  s3Bucket: rome
ignoreMap:
  - Alamofire:
    - name: Alamofire
      platforms: [Mac]
currentMap:
  - Alamofire:
    - name: Alamofire

with the following Rome command:

rome upload --concurrently --cache-prefix travis --no-skip-current

I've revised my Romefile to this:

cache:
  local: ~/Library/Caches/Rome

currentMap:
- ios-protobuf:
  - name: FaireProtobuf

Here's the commands I'm running:

rome upload --no-skip-current // Uploads my framework's dependencies, but not my framework

rome upload --no-skip-current ios-protobuf -v // Uploads nothing, outputs nothing

rome upload --no-skip-current FaireProtobuf -v // Uploads nothing, outputs nothing

One thing to note: My project has a regular .xcodeproj file, as well as a Package.swift. Not sure if that has any effect.

[tmspzz]

One thing to note: My project has a regular .xcodeproj file, as well as a Package.swift. Not sure if that has any effect.

No, that shouldn't matter. But it does need a Cartfile.resolved

Try rome upload --no-skip-current -v

[mpdifran]

It does contain a Cartfile.resolved:

github "Faire/swift-protobuf" "1.14.1"

Running rome upload --no-skip-current -v

11:04:58 2021-01-13 - Copying .swift-protobuf.version to: /Users/markdifranco/Desktop/Rome/swift-protobuf/.swift-protobuf.version-1.14.1
11:04:58 2021-01-13 - Copied .swift-protobuf.version to: /Users/markdifranco/Desktop/Rome/swift-protobuf/.swift-protobuf.version-1.14.1

[tmspzz]

Does carthage archive work? I assume FaireProtobuf.framework is the name of the binary. Also, I assume it's dynamic since you haven't specified otherwise.

If you try with Alamofire does it work? There shouldn't be any difference.

Also, i see that the currentMap contains ios-protobuf and the Cartfile.resolved contains swift-protobuf

But from your log, not ever protobuff is being uploaded. What version of carthage are you using?

[mpdifran]

Ah that was the issue. carthage archive works, but I hadn't run it yet (which in hindsight is pretty obvious). Once the archive succeeded, Rome picked up on the framework and cached it.

Thanks for helping me debug! I'll take a look at the README to see if there's details that can be added.