Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Minio support via AWS Service Endpoint override #119

Merged
merged 11 commits into from
May 23, 2018
Merged

Add Minio support via AWS Service Endpoint override #119

merged 11 commits into from
May 23, 2018

Conversation

tmspzz
Copy link
Owner

@tmspzz tmspzz commented May 3, 2018 •
edited
Loading

See #118 , #121

@hlintBot
Copy link

hlintBot commented May 3, 2018 •
edited
Loading

2 Warnings
⚠️ src/Lib.hs#L476 - Found Reduce duplication

 1frameworkNameWithFrameworkExtension = appendFrameworkExtensionTo f
 2platformBuildDirectory = carthageBuildDirectoryForPlatform platform
 3frameworkDirectory
 4  = platformBuildDirectory </> frameworkNameWithFrameworkExtension
 5dSYMNameWithDSYMExtension
 6  = frameworkNameWithFrameworkExtension <> ".dSYM"
 7dSYMdirectory
 8  = platformBuildDirectory </> dSYMNameWithDSYMExtension
 9bcSybolMapPath d = platformBuildDirectory </> bcsymbolmapNameFrom d
10

Why Not

1Combine with src/Lib.hs:538:5
⚠️ src/Utils.hs#L277 - Found Use &&&

1zip
2  (map (repoNameForFrameworkName reverseRomeMap . _frameworkName)
3     frameworkNames)
4  (map _frameworkVersion frameworkNames)

Why Not

1map
2  ((repoNameForFrameworkName reverseRomeMap . _frameworkName)
3     Control.Arrow.&&& _frameworkVersion)
4  frameworkNames

Generated by 🚫 Danger

@tmspzz tmspzz changed the title Add Minio support via AWS Service Endpoit override Add Minio support via AWS Service Endpoint override May 3, 2018
@tmspzz tmspzz merged commit 7752e54 into master May 23, 2018
@tmspzz tmspzz deleted the feature/minio branch May 23, 2018 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thii thii thii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmspzz @hlintBot @thii