Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to lts 11.13 #128

Merged
merged 7 commits into from
Jul 3, 2018
Merged

Update to lts 11.13 #128

merged 7 commits into from
Jul 3, 2018

Conversation

tmspzz
Copy link
Owner

@tmspzz tmspzz commented Jun 13, 2018

No description provided.

@hlintBot
Copy link

hlintBot commented Jun 18, 2018

3 Warnings
⚠️ src/Caches/Local/Downloading.hs#L169 - Found Reduce duplication

1frameworkNameWithFrameworkExtension = appendFrameworkExtensionTo f
2platformBuildDirectory = carthageBuildDirectoryForPlatform platform
3frameworkDirectory
4  = platformBuildDirectory </> frameworkNameWithFrameworkExtension
5

Why Not

1Combine with src/Caches/Local/Downloading.hs:199:5
⚠️ src/Lib.hs#L476 - Found Reduce duplication

 1frameworkNameWithFrameworkExtension = appendFrameworkExtensionTo f
 2platformBuildDirectory = carthageBuildDirectoryForPlatform platform
 3frameworkDirectory
 4  = platformBuildDirectory </> frameworkNameWithFrameworkExtension
 5dSYMNameWithDSYMExtension
 6  = frameworkNameWithFrameworkExtension <> ".dSYM"
 7dSYMdirectory
 8  = platformBuildDirectory </> dSYMNameWithDSYMExtension
 9bcSybolMapPath d = platformBuildDirectory </> bcsymbolmapNameFrom d
10

Why Not

1Combine with src/Lib.hs:538:5
⚠️ src/Utils.hs#L277 - Found Use &&&

1zip
2  (map (repoNameForFrameworkName reverseRomeMap . _frameworkName)
3     frameworkNames)
4  (map _frameworkVersion frameworkNames)

Why Not

1map
2  ((repoNameForFrameworkName reverseRomeMap . _frameworkName)
3     Control.Arrow.&&& _frameworkVersion)
4  frameworkNames

Generated by 🚫 Danger

@tmspzz tmspzz merged commit 2cdb488 into master Jul 3, 2018
@tmspzz tmspzz deleted the feature/lts-11.13 branch July 3, 2018 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants