-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom script engines for donwloading/uplaod/listing #148
Conversation
Any word on this PR? 👍 for getting it in. We need to add caching support, but have on our on-site file store that we would like to use instead of S3. |
@grioja I work on this on and off, contributions are welcome. In the mean time, setting up minio https://www.minio.io/ might get you around the problem. |
@BalestraPatrick basically the path is laid out. What is missing is the implementation. Whenever you read |
I have resolved the conflicts are rebased on #179 |
Can you elaborate a little bit on the idea for your implementation? I did actually get to fix the conflicts locally but didn't push them, oops. Happy to see you had time to do it! |
Generated by 🚫 Danger |
@BalestraPatrick the idea is to invoke a script at First argument is always the command currently being executed: i.e. In case of
In case of
In case of
scripts should return exit code 0 on success and be passed stdin, stdout and stderr descriptors by rome itself. You can use Turtle to invoke the scripts. Important: the script is going to be invoked concurrently so it should either have no state or support current execution. |
This is to start with so that things don't get too complicated. Alternatively the idea was to pass a description of the data structure that the commands rely upon to the script. However I don't have a concise solution for this. One idea is to use JSON to describe them but I think for a first implementation this is an overkill. Eventually if all the contextual information that the commands have is required also in the script (and cannot be extracted from the paths) then I'll reconsider. |
See #146.
It should also work for: #120, #139, #116