Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #25 #26

Merged
merged 9 commits into from
Oct 2, 2016
Merged

Fixes #25 #26

merged 9 commits into from
Oct 2, 2016

Conversation

2016rshah
Copy link
Contributor

As we discussed in #25, I refactored all the string types. Specifically, Location, Version, FrameworkName, and GitRepoName.

@2016rshah
Copy link
Contributor Author

(Oops, feel free to squash the commits!)

tmspzz
tmspzz approved these changes Oct 2, 2016
View reviewed changes
Copy link
Owner

@tmspzz tmspzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, well done! Thanks!

@tmspzz tmspzz merged commit ef1cfac into tmspzz:master Oct 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmspzz tmspzz tmspzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2016rshah @tmspzz