Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/multiple platforms #42

Merged
merged 10 commits into from
Feb 6, 2017
Merged

Conversation

r-peck
Copy link
Contributor

@r-peck r-peck commented Feb 4, 2017

WIP - Still needs documentation update for usage and parsing of list command output, but wanted to get the functionality under review.

Implements #36. Platforms can be specified with the --platform option (rome upload --platform ios,watchos). The cache key is now <framework_name>/<platform>/<framework_name>.framework-<version>.zip.

When using the list command, the output format has been updated to <git-repository-name> <version> : ((+|-)<platform-name>){1-4}, for example FrameworkA 1.0.0 : +iOS -watchOS

@tmspzz
Copy link
Owner

tmspzz commented Feb 4, 2017

Thanks, I'll start reviewing ;)

@tmspzz tmspzz self-requested a review February 5, 2017 01:29
@tmspzz
Copy link
Owner

tmspzz commented Feb 5, 2017

I have submitted a pull request to your branch.

Copy link
Owner

@tmspzz tmspzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See changes in pull request to your pull request

@r-peck r-peck force-pushed the feature/multiple-platforms branch 3 times, most recently from 21894f2 to 5fde36e Compare February 6, 2017 15:17
@r-peck r-peck force-pushed the feature/multiple-platforms branch from 4ff89c7 to a10296a Compare February 6, 2017 17:41
@tmspzz
Copy link
Owner

tmspzz commented Feb 6, 2017

@r-peck Will do you a separate pull request for the README.md ? Do you also want to provide a sample script to parse the output of list?

These are the last two open issues.

@r-peck
Copy link
Contributor Author

r-peck commented Feb 6, 2017

I am working to add both of those to this PR. Hoping to have that ready in the next day or two. Would you prefer a separate PR?

@tmspzz
Copy link
Owner

tmspzz commented Feb 6, 2017 via email

@r-peck
Copy link
Contributor Author

r-peck commented Feb 6, 2017

@blender Updated the README to reflect the --platform option added a short example on parsing the output of list to a similar result to how rome list --missing might have been used before.

@tmspzz tmspzz merged commit d37d69f into tmspzz:master Feb 6, 2017
@tmspzz
Copy link
Owner

tmspzz commented Feb 6, 2017

@r-peck Merged 🎉

@r-peck r-peck deleted the feature/multiple-platforms branch February 6, 2017 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants