Wrap inflation errors #500
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuSh
reviewed
Feb 23, 2023
KuSh
reviewed
Feb 23, 2023
mastermatt
force-pushed
the
wrap_inflation_errors
branch
from
239eefb to
e62c432
Compare
`pako` has a tendency to throw obscure error strings e.g. "too many length or distance symbols", which can make gracefully handling bad input difficult when an error is thrown from `parseLoginRequest`. This wraps the inflation step to allow throwing a dedicated error with a static message for inflation issues, while still making the original error available.
mastermatt
force-pushed
the
wrap_inflation_errors
branch
from
e62c432 to
67be597
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Request in PR form.
pakohas a tendency to throw obscure error strings e.g. "too many length or distance symbols", which can make gracefully handling bad input difficult when an error is thrown fromparseLoginRequest.This wraps the inflation step to allow throwing a dedicated error with a static message for inflation issues, while still making the original error available.