Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension build fallback does not work on some windows platforms #161

Closed
acksmaggart opened this issue Apr 25, 2019 · 1 comment
Closed

Extension build fallback does not work on some windows platforms #161

acksmaggart opened this issue Apr 25, 2019 · 1 comment

Comments

@acksmaggart
Copy link
Contributor

As discussed in issue #88, setup.py includes a fallback to pure python when building the pvectormodule extension does not work. However, the fallback is not triggered on some Windows machines because the custom build module is not catching the FileNotFoundError that is thrown indicating that the windows SDK has not been installed.
This was referenced Apr 25, 2019
Merged
Closed
@acksmaggart
Copy link
Contributor Author

Fixed in PR #162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@acksmaggart