Added FileNotFoundError to custom_build_ext.run(). #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did adding this help? If so, please also add it to line 51 in the same file. It's more or less a duplicate used for testing. Common code could potentially be factored out. |
|
It did fix it, luckily. I just pushed an update adding it to line 51. Let me know if there is anything else. (I'm still planning on finishing the wheel CI stuff, by the way) |
|
Great, thanks! |
|
This seems to be throwing a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds
FileNotFoundErrorto theexceptlist in setup.py after verifying that it fixed the installation problems on the test machine, which was Windows Server 2012 R2.Fixes issue #161.