Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add building of native wheels on TravisCI #170

Merged
merged 1 commit into from
Jun 1, 2019
Merged

Add building of native wheels on TravisCI #170

merged 1 commit into from
Jun 1, 2019

Conversation

salekseev
Copy link
Contributor

@salekseev salekseev commented May 16, 2019

This addresses building of native wheels for #88

Sorry for such convoluted handling of osx due to TravisCI not having first class support for python on osx (travis-ci/travis-ci#9929).

Upload to be added.

- ${PIP} install cibuildwheel==0.10.2
script:
- cibuildwheel --output-dir dist
- name: pypy3.5
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manylinux does not yet have support for PyPy pypa/manylinux#38

@tobgu
Copy link
Owner

tobgu commented May 16, 2019

Awesome! I'll have a look in the coming days.

@salekseev
Copy link
Contributor Author

Awesome! I'll have a look in the coming days.

Good afternoon. Just wanted to see if you had a chance to look at the PR. Thanks.

Copy link
Owner

@tobgu tobgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed feedback!

I just have one question regarding the pip versions. It may be perfectly fine.

Apart from that, looks good!

.travis.yml Show resolved Hide resolved
@salekseev
Copy link
Contributor Author

Sorry for the delayed feedback!

I just have one question regarding the pip versions. It may be perfectly fine.

Apart from that, looks good!

I think I've addressed the comment about pip2 inline. Do you plan on publishing wheels for existing version after merge or after a new tag is cut?

@tobgu tobgu merged commit a559cea into tobgu:master Jun 1, 2019
@tobgu
Copy link
Owner

tobgu commented Jun 1, 2019

That would be on a new tag with this merge included.

@tobgu
Copy link
Owner

tobgu commented Jun 1, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants