Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert SpeedMax and SpeedAvg in Drive (km->mi) #37

Merged
merged 1 commit into from
May 3, 2021
Merged

Convert SpeedMax and SpeedAvg in Drive (km->mi) #37

merged 1 commit into from
May 3, 2021

Conversation

alecdoconnor
Copy link
Contributor

Already implemented in DriveDetails, logic was duplicated exactly in this pull request

@alecdoconnor
Convert SpeedMax and SpeedAvg in Drive (km->mi)
7693581 
Already implemented in DriveDetails, logic was duplicated exactly in this pull request
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
100.0% 100.0% Duplication

@alecdoconnor alecdoconnor mentioned this pull request May 3, 2021
Closed
@tobiasehlert tobiasehlert self-requested a review May 3, 2021 16:54
@tobiasehlert tobiasehlert added bug Something isn't working go Pull requests that update Go code good first issue Good for newcomers solved This issue was solved labels May 3, 2021
@tobiasehlert
Copy link
Owner

Awesome catch, thanks @alecdoconnor 👍

@tobiasehlert tobiasehlert merged commit e78304c into tobiasehlert:main May 3, 2021
@tobiasehlert tobiasehlert linked an issue May 3, 2021 that may be closed by this pull request
Drive Speeds Not Being Converted #38
Closed
@tobiasehlert tobiasehlert removed the good first issue Good for newcomers label May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasehlert tobiasehlert tobiasehlert approved these changes

Assignees
No one assigned
Labels
bug Something isn't working go Pull requests that update Go code solved This issue was solved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drive Speeds Not Being Converted
2 participants
@alecdoconnor @tobiasehlert